“My question is this: What do you do about a person who is photographing locations you might consider to be a possible target of terrorism “
If you love America, not a damned thing. America has always meant anywhere you could legally stand, you could take a photo. The USSR and dictatorship nations have LOTS of places you cannot photograph things you can plainly look at.
I once had a foreign guest. She kept asking if it was allowed to take a photo, here, there,, etc. I mean in clearly public places.
I would be utterly ashamed of America for that answer to sometimes become “no you cannot take a photo of THAT building, THAT bridge”, etc.
This is utterly UNAMERICAN.
A case of what is good and great about America being a benefit to our enemies.