Start Trek claimed that they had invented a society which was not based on money, and the purpose was to better themselves. That's great if everyone gets to be a starship captain. But they continually showed people in occupations that even today people don't choose to "better themselves," rather for the money so they can eat. There are people shown sweeping floors, bartenders, etc. So they are no egalitarian based upon the person's wishes, rather a class based meritocracy, which is never explored.
And if replicators fixed the problem of scarcity, why is it that there is only one Enterprise? Why can't every family have their own space ship, and seed the galaxy like Space Family Robinsons?