None of that stuff is illegal in a normal state (other than NJ)except the rifle with defaced S#.
It is if you have a dishonorable discharge from the armed forces. Since they said he deserted, and it was 8 years before he was returned to Navy control, I suspect that's what he has. Although it's possible he has a lessor form of a less than honorable discharge, and then "It depends".