They were terrorists. In their practices they were more restrained than AQ or Hamas, on a par with the IRA and not around as long. But terrorists they were. It doesn't matter how much lipstick you put on the pig.
Terrorism targets civilians as do the IRA, AQ, Hezbollah and Hamas.
"International and Domestic Terrorism - FBI definitions
Terrorism is defined as violent or criminal acts against a civilian population for the purpose of coercion, and promoting a political cause or agenda. When those crimes occur within the United States, and are perpetrated by an individual or group associated with a domestic cause, they are defined as domestic terrorism. When they are perpetrated by an individual or group from outside the U.S., then it is defined as international terrorism. Also, beginning 1986 it has been a violation of federal law for any group or individual to commit an act of terrorism against U.S. interests or U.S. citizens even in a foreign country. "
http://c21.maxwell.af.mil/cts-fed.htm
"How do you define terrorism?
The Intelligence Community is guided by the definition of terrorism contained in Title 22 of the US Code, Section 2656f(d):
—The term “terrorism” means premeditated, politically motivated violence perpetrated against noncombatant targets by subnational groups or clandestine agents, usually intended to influence an audience."
http://www.cia.gov/terrorism/faqs.html
Your laundry list indicates the targets of the Israeli insurgency were Military and Government.
Your view of history is upside down. You condemn people fighting for survival and side with the British who abrogated all responsibility, legal and moral, to side with the Arabs.
The British were an occupying force from a continent away acting in disregard of international commitments, a Mandate, and a responsibility imposed upon them and accepted by them by the victors of WW1, the Treaty of Versailles, and the League of Nations.
The bad guys here were the British who violated both their word and their moral authority in failing to give Jews a country and in siding with the Arabs. They whittled away the land of Israel giving the lions share to Transjordan to placate the Hashemites for their loss of Mecca and Medina. They prohibited Jewish immigration to placate the local Arabs thus adding immeasurably to the number of Jews left in Hitler's Europe. They limited Jewish land purchases. Both limitations were in direct contravention to the Mandate they had accepted and were obligated to abide.
The British actively sided, supported and fought with the Arab countries who attacked Israel after the UN voted its creation and Israel was declared a country in 1948.
History has become so politicized that simple concepts have lost all meaning. In Iraq the left calls acts of terror perpetrated on civilians an insurgency. BBC, Reuters say one man's terrorist is another man's freedom fighter again disregarding the targets of even 9/11. The far left calls the acts of Western Governments terrorism. You rush to label acts of war against an occupying power terrorism focusing on the identity of the perpetrators and not on the acts or the intended victims.
Neither the left nor your approach are correct. There still exists the concept of insurgency outside of terrorism and outside of regular forces in uniform.