I’m not a big fan of people telling their children of their horrendous mistakes in youth. Children need to be children and expect the best of their parents. That’s just me, of course.
I generally agree, UNLESS there is a possibility of them finding out from someone else.
There are mistakes I made as a youth that no one else knows about and no one ever will. Then there are mistakes that I made that were known to other family members. I told my children about these because I did not want them to someday hear about them from a cousin.