Scots...not Scotch.;-)
Although I have an English surname, I am predominatly “Scots-Irish”. I belong to the “Scotch-Irish” Society of the U.S. out of Pa. They insist on being called “Scotch” rather than “Scots”. I believe Scots is the correct term, however.
So, whatever they want to be called is fine with me.
Scotch is the correct pronunciation among the Scotch-Irish of VA, NC, SC and TN. It’s a linguistic throwback, like many unique words in the foothills and mountains here. I’ll stick with their name for themselves, personally.
Another linguistic oddity pertainining to the Shenandoah Valley, would be that up is down, and down is up. If you’re going down the Valley, you’re headed toward DC. If you’re going up the Valley, you’re headed toward NC. It refers to altitude instead of north and south.