" Great cinematography and costumes, but all time favorite? "
Let's not forget the music ...
I've already forgotten the music, but I only saw it a couple of times a few years ago. Kubrick is excellent at creating memorable scenes. The ones I remember most from that movie are of Lady Lyndon signing her name for more money.